[PULP-1956] Add domain support to TaskSchedule#7822
Open
jobselko wants to merge 1 commit into
Open
Conversation
jobselko
force-pushed
the
ts_domain
branch
3 times, most recently
from
ad5ae66 to
2a8bd2b
Compare
gerrod3
reviewed
Jun 29, 2026
Comment on lines
+282
to
+286
| pulp_domain = RelatedField( | ||
| help_text=_("Domain this schedule belongs to."), | ||
| read_only=True, | ||
| view_name="domains-detail", | ||
| ) |
Contributor
There was a problem hiding this comment.
One thing to note is that once you add a pulp_domain relationship to a model it will then be scoped to that domain and thus having a read-only field on the serializer is redundant (the domain is always present in the objects href). The other way we've added a domain relation without the object becoming a part of the domain is by naming the field domain like we did for UserRole and GroupRole.
Member
There was a problem hiding this comment.
Ohhh, if anything this is not a bugfix afaics. Scheduled tasks have a very limited scope to global housework duties.
So what really is the ask? Making the task schedule itself a domain scoped object?
closes pulp#7829 Assisted By: Claude Opus 4.6
jobselko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Checklist
See: Pull Request Walkthrough